Pin Bag

Can I have buttons (the ones that attach by needle pins) on by carry on bag in an airplane?

or will they be confiscated?

They’ll be fine. You’re allowed to have knitting needles and other cutting tools, so pins would not be a problem.

Here’s your definitive list:

http://www.tsa.gov/travelers/airtravel/prohibited/permitted-prohibited-items.shtm#4

[...]